search

libamtrack / ReGenerator

R packagE Generator
MIT License
1 stars 0 forks source link

C wrapper generator for R's .Call interface #24

Closed ptyszko closed 3 years ago

ptyszko commented 3 years ago

It's likely that the .C interface will also need its own C wrappers. This PR does not consider them.

ptyszko commented 3 years ago

Added suggested comments and made suggested changes where applicable

grzanka commented 3 years ago

@ptyszko what is the minimum required python version ?

(rege) (base) ➜  ReGenerator git:(wrapper-generator-C-wrapper) python scripts/header_parser.py --help
Traceback (most recent call last):
  File "scripts/header_parser.py", line 92, in <module>
    from typing import Union, Literal
ImportError: cannot import name 'Literal' from 'typing' (/home/grzanka/anaconda3/lib/python3.7/typing.py)
ptyszko commented 3 years ago

3.8 for type hints. Could be lower if I removed them, but I would prefer not to

grzanka commented 3 years ago

3.8 for type hints. Could be lower if I removed them, but I would prefer not to

can you add a readme information about that, otherwise code looks OK

ptyszko commented 3 years ago

3.8 for type hints. Could be lower if I removed them, but I would prefer not to

can you add a readme information about that, otherwise code looks OK

Added.