search

libamtrack / ReGenerator

R packagE Generator
MIT License
1 stars 0 forks source link

Generate roxygen2-compatible documentation comments #35

Closed ptyszko closed 2 years ago

ptyszko commented 2 years ago

Resolves #29

grzanka commented 2 years ago

@ptyszko is it still draft ?

ptyszko commented 2 years ago

@ptyszko is it still draft ?

As soon as all checks pass this will be ready

ptyszko commented 2 years ago

@grzanka is it okay to merge? I'd like to put this to work in the main repo before the deadline (tomorrow at 6pm)

ptyszko commented 2 years ago

@grzanka Added the suggested changes, except for the last one as I think it would give the wrong impression about what prepare.py is for. Instead I added a note in its help message.

I have a very poor Internet connection today so I won't be able to address any more comments. If you have no issues with the changes, could you merge the PR yourself?

grzanka commented 2 years ago

@grzanka Added the suggested changes, except for the last one as I think it would give the wrong impression about what prepare.py is for. Instead I added a note in its help message.

I have a very poor Internet connection today so I won't be able to address any more comments. If you have no issues with the changes, could you merge the PR yourself?

Sure, I can merge it, but the tests are failing. Can you fix that at least ?

ptyszko commented 2 years ago

The tests should pass now