libantioch / antioch

C++ Chemical Kinetics, Thermodynaimics, and Transport Library
https://libantioch.github.io/
Other
22 stars 17 forks source link

Xml parser #174

Closed SylvainPlessis closed 8 years ago

SylvainPlessis commented 8 years ago

Here is the PR related to issue #173.

It has all the discussed features:

Two expected failures tests have been added to test for these two new restrictions, the existing test have been somewhat expanded, meaning some name="k0" have been put in the first rate constant's block to test for this configuration.

The XFAIL tests are clones of the normal test, with one reaction containing one feature that Antioch now find to be offensive.

SylvainPlessis commented 8 years ago

On this, gentlemen, I'm heading for my bed.

See ya!

pbauman commented 8 years ago

Closed in favor of #175. Thanks @SylvainPlessis!