search

libantioch / antioch

C++ Chemical Kinetics, Thermodynaimics, and Transport Library
https://libantioch.github.io/
Other
22 stars 17 forks source link

Consistency/Consolidation in Parsing Methods #176

Open pbauman opened 8 years ago

pbauman commented 8 years ago

Some methods we take a pointer to a parser that's already created (e.g. ChemicalMixture constructor). Others, we don't give that option and construct the parser internally (e.g. `read_reaction_set_data1). It would be nice for the user to instantiate one parser object and use it everywhere, if appropriate.

pbauman commented 6 years ago

There are some methods that live in global namespace, e.g. read_reaction_set_data, that should be in ParserBase and then calls methods that can be implemented in subclasses. This is once example. We definitely want to consolidate all these because the parsing is spread out everywhere making it really hard to follow.