search

libantioch / antioch

C++ Chemical Kinetics, Thermodynaimics, and Transport Library
https://libantioch.github.io/
Other
22 stars 17 forks source link

NASA Curve Fit Refactor, Part 2 #189

Closed pbauman closed 8 years ago

pbauman commented 8 years ago

This is the second part of the NASA curve fit refactoring to facilitate updates/fixes to the parsing. This PR updates the internals of NASA9CurveFit to only store 9 coefficients. NASA9CurveFit now will only accept coefficients in the "nine form". CEACurveFit only accepts coefficients in the "10 form" and will remap the 10 coefficients to the underlying 9.

Note this preserves backward compatibility with CEACurveFit which has been around awhile. NASA9CurveFit is new so we don't need to worry about backward compatibility.

With this form for construction, we can easily apply ASCII (CEACurveFit) vs. XML parsing (NASA9CurveFit).

pbauman commented 8 years ago

Threw on a commit that throws an error if thermo parsing is called with the wrong curve fit type.