libantioch / antioch

C++ Chemical Kinetics, Thermodynaimics, and Transport Library
https://libantioch.github.io/
Other
22 stars 17 forks source link

Fix XML Parsing for NASA9 Thermo #190

Closed pbauman closed 8 years ago

pbauman commented 8 years ago

This PR fixes XML parsing for NASA9 style polynomials. I added a xml_inputs directory to the share directory and we will now distribute an XML style input of NASA9 data; that file was pull from FIN-S. I also use that file for the unit testing that was added. One of the nice things about that file is that it has coefficients for extended intervals. As part of adding the distribution of the file to the build system, I also clean up make distcheck and make install. The XML parsing still only supports NASA9. A future PR will generalize this to support either NASA7 or NASA9.

As part of this, I split up the NASA9 unit test to reuse the "exact data". Further, I had to add a (kind of funky) parsing helper function to strip newline characters from a vector of strings. This popped up when I first started testing parsing the coefficients from the XML file.

Going to leave this up for comments until I add NASA7 parsing support.