libantioch / antioch

C++ Chemical Kinetics, Thermodynaimics, and Transport Library
https://libantioch.github.io/
Other
23 stars 17 forks source link

Support reaction chemistry in S3D #20

Closed nicholasmalaya closed 9 years ago

nicholasmalaya commented 10 years ago

We want to enhance antioch to fully support the reaction chemistry in S3D. Using Jackie Chen's paper on S3d as a model document, we the following capabilities:

S3D assumes an ideal gas mixture, so the equation of state is all set. I need to read through the documentation more carefully, and then will propose Antioch files to modify.

nicholasmalaya commented 10 years ago

S3d and boxlib are both using chemkin chemistry, which is detailed here. Modifications to Antioch will be contained in: src/transport/include/antioch/ and src/transport/src/. We also really need to add doxygen markup to document the models in use. Cantera is beating us badly in this department.

nicholasmalaya commented 10 years ago

First draft of the document is available here. This is not a permanent location, but will be integrated into the Antioch Doxygen and documentation if accepted.

A better version of the underlying transport document is here.

nicholasmalaya commented 10 years ago

Bob gave an OK to this document on Friday, so I am planning on proceeding with the actual implementation. Any comments welcome.

SylvainPlessis commented 9 years ago

Isn't this the whole transport PR craziness?

Shouldn't we delete this issue?

nicholasmalaya commented 9 years ago

Yes. This issue is deprecated. Might be worth plopping a few references to the actual tickets that resolved this issue before closing it, however.

SylvainPlessis commented 9 years ago

Done.