search

libantioch / antioch

C++ Chemical Kinetics, Thermodynaimics, and Transport Library
https://libantioch.github.io/
Other
22 stars 17 forks source link

Eigen::Array doesn't currently wrap other vectors? #208

Closed roystgnr closed 8 years ago

roystgnr commented 8 years ago

This looks like a regression in my version of Eigen and not anything wrong with Antioch, so I'm disabling that test set.

For future reference, the compilation failure was:

/usr/include/eigen3/Eigen/src/Core/Array.h: In instantiation of ‘Eigen::Array<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols>::Array(const T&) [with T = long int; _Scalar = std::valarray<float>; int _Rows = 5; int _Cols = 1; int _Options = 0; int _MaxRows = 5; int _MaxCols = 1]’:
...
/usr/include/eigen3/Eigen/src/Core/Array.h:173:31: error: no matching function for call to ‘Eigen::Array<std::valarray<float>, 5, 1, 0, 5, 1>::_init1(const long int&)’
pbauman commented 8 years ago

What's the version of Eigen for future reference?

roystgnr commented 8 years ago

Eigen 3.2.92 according to /usr/include/eigen3/Eigen/src/Core/util/Macros.h; 3.3~beta1-2 according to Ubuntu dpkg.

roystgnr commented 8 years ago

Oh, and I presume you're thinking along the same lines as me: if they eventually fix this then we should definitely re-enable these tests but wrap them in EIGEN_VERSION_AT_LEAST-based cpp directives.

pbauman commented 8 years ago

Oh, and I presume you're thinking along the same lines as me: if they eventually fix this then we should definitely re-enable these tests but wrap them in EIGEN_VERSION_AT_LEAST-based cpp directives.

Indeed. :) Thanks!