API Consistency Between IdealGasMicroThermo and StatMechThermodynamics

libantioch / antioch

C++ Chemical Kinetics, Thermodynaimics, and Transport Library

https://libantioch.github.io/

Other

23 stars 17 forks source link

API Consistency Between IdealGasMicroThermo and StatMechThermodynamics #238

Closed pbauman closed 7 years ago

pbauman commented 7 years ago

Right now, we don't have complete consistency in the API between these two classes, even though the intent is that they be used interchangeably. For example, cv(), cp(), cv_el(), and probably more, are missing from IdealGasMicroThermo but are present in StatMechThermodynamics.

I'm thinking we introduce a MicroThermoBase CRTP base class and have each of IdealGasMicroThermo and StatMechThermodynamics appropriately subclass.

roystgnr commented 7 years ago

Sounds good to me.

pbauman commented 7 years ago

Addressed in #240.