RIght now we force the user to externally construct a NASAEvaluator object and then hold on to it so that IdealGasMicroThermo only holds a reference to it. But since IdealGasMicroThermo is really an "Evaluator" class, it would be better to internally construct the NASAEvaluator and then take a reference to the NASAThermoMixture. All the Evaluator classes are lightweight construction, so this makes sense. The problem will be there's not way that I can see to make the class backward compatible because we'll have to change the template arguments. So we'll need to create a new class IdealGasThermo (other suggestions welcome) and then deprecate IdealGasMicroThermo.
RIght now we force the user to externally construct a
NASAEvaluatorobject and then hold on to it so thatIdealGasMicroThermoonly holds a reference to it. But sinceIdealGasMicroThermois really an "Evaluator" class, it would be better to internally construct theNASAEvaluatorand then take a reference to theNASAThermoMixture. All the Evaluator classes are lightweight construction, so this makes sense. The problem will be there's not way that I can see to make the class backward compatible because we'll have to change the template arguments. So we'll need to create a new classIdealGasThermo(other suggestions welcome) and then deprecateIdealGasMicroThermo.