libantioch / antioch

C++ Chemical Kinetics, Thermodynaimics, and Transport Library
https://libantioch.github.io/
Other
22 stars 17 forks source link

Consolidate All Parsing Methods #260

Open pbauman opened 5 years ago

pbauman commented 5 years ago

There's scattered global functions for parsing things, but these should just be base class methods in the ParserBase object and then using virtual functions for implementation specific things. Right now, this is 1. Confusing as hell to figure out what's going on, 2. Makes it harder to update to use new features, e.g. #254 where we can now specify the gas mixture to select what we want if there's multiple sections in the XML file; right now we can't use it for kinetics., 3. Messy.

250 will be a step in this direction. This will also help with #249.