libasys / calendarplus

Calendar+ App for ownCloud 8.1 or later, lower version not supported
36 stars 8 forks source link

1.0.5 - Reoccurring Events Seem Buggy #118

Open MNOCFan opened 9 years ago

MNOCFan commented 9 years ago

Issue 1 1) Add a reoccurring event over M-F. 2) Delete Wednesdays event. Result: Thursday and Fridays events back up a day to Wednesday and Friday is ultimately removed.

Issue 2 1) Add a reoccurring event over M-F when running over the end of the month to the beginning of the next. Example: Aug 31st-Sept 4th. 2) At first, not all the events show on the calendar until the calendar is refreshed. 3) Deleting an event somewhere in the middle causes more weird behavior.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

pravussum commented 9 years ago

I can add something to issue 2: It seems that in month view the recurring events are only recalculated up to the end of the month. If there are some days of the next month visible and one recurrence of the event in that next month is visible as well, it only gets redrawn on refresh). I hope I made myself clear enough :-/

MNOCFan commented 9 years ago

@pravussum While I can almost agree with you, in one of my tests I did see the event get created on the 31st and the 1st, but not on the 2nd, 3rd, or 4th date. Still, something buggy about it....

libasys commented 9 years ago

please update your app to current master 1.0.5, this should be fixed! Added very important js fix fot timeline, if not no events loaded!

MNOCFan commented 9 years ago

@libasys I have updated and this issue is still occurring.

libasys commented 9 years ago

ok i can't reproduce that behaviour! I have no problem with creation of a recurring rule of an event from monday till friday!

MNOCFan commented 9 years ago

@libasys There doesn't seem to be an issue with creating an event reoccurring from M-F, however, after creating that event, try deleting one event within that series. Try deleting Wednesday or something in the middle of the events week. Pay attention to the events after the one you delete. It doesn't behave as intended.

libasys commented 9 years ago

I have tested this with deletion, i have no Problems! Happens that with allday events?

MNOCFan commented 9 years ago

@libasys here are the steps I am doing to reproduce: 1) Create an event on Monday and mark it to reoccur daily until Friday 2) Delete the Wednesday within that reoccurring event 3) In my environment, after deleting Wednesday, Thursdays event moves to Wednesday. 4) Now my week looks like this - Event Monday, Tuesday, Wednesday, and Friday.

ev0lister commented 9 years ago

Cannot reproduce the issue you are describing. When I delete a event from a series it is just working fine. Using current version 1.0.7. @MNOCFan have you tried a fresh calendar to see whether this is maybe related to other entries in your current calendar?

2015-08-27 14_12_16-calendar

pravussum commented 9 years ago

I can kindof reproduce this...

basicly:

pravussum commented 9 years ago

Same use case works in the week after. Could it be, that it depends on whether the current day is within the timespan? @ev0lister: can you try that in the current week please?

libasys commented 9 years ago

have you tested the advanced repeating rules like -> customize -> weekly -> choose mo,tue,thu,fr? without wednesday?

pravussum commented 9 years ago

Just tested (in the current week), that works.

ev0lister commented 9 years ago

Have tested it in current week with non-advanced rules (e.g. just selected DAILY) and this is also working for me.

libasys commented 9 years ago

Please retest current master of calendar+! Should be fixed!

MNOCFan commented 9 years ago

I have tested this with the latest version (1.0.7) with an existing calendar and a brand new calendar and it still behaves buggy. Here are my steps to recreate.

I certainly hope I am not the only one experiencing this issue....

libasys commented 9 years ago

Have you tested this Master here on github or downloaden from AppStore? The fix is only here on Master !

MNOCFan commented 9 years ago

@libasys I only did the one-click update. I will try downloading from Github.

MNOCFan commented 9 years ago

@libasys I have tested with the Github version with the same results. I notice there are "Exceptions" listed within the series. They are not the correct dates that I deleted rather they are the adjacent. I will try to get some snapshots to post of what I am seeing.

MNOCFan commented 9 years ago

I added a new event from M-F addevent event Deleting the Wednesday event. deleteevent After deleting Wednesday, Thursday disappears. afterdelete Additionally, the "exception" date is wrong. theexceptionwrong

libasys commented 9 years ago

I think this a timezone issue, what timezone do you have selected?

MNOCFan commented 9 years ago

Chicago

libasys commented 9 years ago

I can't reproduce this issue, i changed tz to Chicago and changed dateformat but all Works well! Can you reproduce this on the Demo http://demo81.libasyscloud.de ?

MNOCFan commented 9 years ago

@libasys Yes, on your demo link I just added 9/7-9/11 and deleted 9/9 and 9/10 deleted instead. Translation was tough, but I made through it! :) demosite

MNOCFan commented 9 years ago

@libasys I uploaded a video onto your demo site under files --> videos called Cal+_Issue2.mp4

Let me know if you can see it ok or not.

pravussum commented 9 years ago

Did a pull from master and just tested with exact dates from @MNOCFan in week view and Chicago time zone - worked.... Tried in the current week - worked as well. Calculation of the recurrence end date also worked correctly (in both Chicago and Berlin timezone). So now it gets interesting...

libasys commented 9 years ago

Ok i can't reproduce testing your example! What Browser and operating System do you use?

pravussum commented 9 years ago

@libasys maybe you can set your OS time to Chicago...

MNOCFan commented 9 years ago

I am on a Windows 8.1 Pro machine and am using latest version of Firefox.

MNOCFan commented 9 years ago

I just tested this on my Ubuntu machine with Firefox and got the same results.

MNOCFan commented 9 years ago

@libasys @pravussum UPDATE: So I am not sure if you guys were testing the reoccurring events by the full day or for a certain time or not, but I have discovered that the "Full Day" reoccurring event is what is broken. If I create an even for a certain time-frame and delete one of the events, it works as expected.

pravussum commented 9 years ago

Retested full day events from 7th of Sep to 11th of Sep with timezone set to Chicago. Deleted the Wednesday event and Wednesday event was removed correctly. So everything working in my setup (on current master).