libasys / calendarplus

Calendar+ App for ownCloud 8.1 or later, lower version not supported
36 stars 8 forks source link

Birthday Calendar (suggestion of rework) #157

Open deMattin opened 9 years ago

deMattin commented 9 years ago

Actual birthday calendar in calendar+ has some issues and I checked the database, how the birthday events are integrated there. Issues are:

I didn't check the code, how and when the birthday events are set in database, but you see in database, that each event is a single day event. I think, this is done, to show the age of contact in calendar+ (which also has the issue using actual date to calculate age and not x. birthday).

  1. I think it would be better, to create a recurring event in calendar+, starting with date of birth
  2. to show the age of contact, there should be used some js or something like that, to calculate the x. birthday on THAT day you are looking at and not the age of contact like it is NOW, when you use calendar+. This way the age won't be syncable any more but I think, this isn't such an issue.
  3. If 2. is not that simple for now, it would probably be better, to simply write the year of birth after contact's name (like it is in old "official" calendar app). This isn't a so bad solution at all.

I understand the approach, to generate single events to give the age of contact in display of calendar+. But if you do this, the contact's birthdays use many more entries in database and have to be filled in Calendar+ starting with day of birth(!) until future (how long to the future? how should this filling be triggered?) and the issue not displaying the x. birthday but the actual age has to be fixed, too.

What do you think?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.