codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
Project coverage is 90.86%. Comparing base (
d7878ac) to head (c6b8d69).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/test_helper.rs | 0.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #865 +/- ## ========================================== - Coverage 95.39% 90.86% -4.53% ========================================== Files 55 55 Lines 10522 10457 -65 ========================================== - Hits 10037 9502 -535 - Misses 485 955 +470 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
danielocfb
The BPF symbolization tests were added as unit tests, because they require a bunch of setup shenanigans that we only had internally to the crate. Conceptually, however, they are very much end-to-end tests that test the public API surface and not just some implementation detail. We really want to preserve the ability to get a good overview of all end-to-end tests in a single location and so with this change we take necessary steps to expose necessary test helpers so that they can be used from end-to-end tests. Furthermore, we move said BPF symbolization tests into tests/blazesym.rs, co-located with most other end-to-end tests.