Closed lavenderfly closed 9 months ago
Can you please just update your commit title to prefix it with
mirror:
? This helps filter commits that are added directly to the mirror repo from those that come from sync-ups with the kernel tree. Ideally, could you also wrap your commit description on 72 characters, please?
This commit still fails the check, can you give me more suggestions? For example, does "mirror:" have to be followed by a space?
Sorry, I wasn't clear enough, can you please add a space after the prefix?
And the initial description was good, it explained better why the change is needed. Here's what I meant:
mirror: Fix CLANG_BPF_CO_RE_PROBE_CMD When global variables are not initialized, the original command will get incorrect results in some versions of clang environment. Signed-off-by: ...
thanks for your patient explanation
When global variables are not initialized, the original command will get incorrect results in some versions of clang environment.
Take clang 10 as an example:
Not initialized (current code):
Initialized (new code):
This difference will affect the checking of clang-bpf-core features.
This part of the code looks like this in the kernel:
This problem may only occur here.