search

libbpf / bpftool

Automated upstream mirror for bpftool stand-alone build.
Other
398 stars 71 forks source link

mirror: Add .mailmap to the repository, sync with kernel's #142

Closed qmonnet closed 6 months ago

qmonnet commented 6 months ago

Add a script to grep for the relevant entries in the .mailmap file of the kernel repository, and use it to build a .mailmap file for the mirror repo.

qmonnet commented 6 months ago

Cc @anakryiko just for your information, in case you were interested in a .mailmap for libbpf.

anakryiko commented 6 months ago

how is this .mailmap file used? Is Github using this automatically?

If you are up sending PR, we can add it to libbpf repo and maybe include it into sync workflow.

qmonnet commented 6 months ago

how is this .mailmap file used? Is Github using this automatically?

The .mailmap is used by git to remap names or emails in commit logs, typically if someone didn't use a canonical form for their name, or if they changed email address. See the documentation for details.

Concretely, if you cloned the repository and run git log in it, you would no longer see my @isovalent.com email for the commits I authored, only the @kernel.org (the sign-offs and other tags in commit description remain unchanged, though).

Alas, GitHub does not support mailmap as far as I know. So it's only when you look locally at the logs, which makes the interest of the whole thing limited, but I thought it would still be nice to replicate this aspect from the kernel repo and account for email address changes when relevant.

If you are up sending PR, we can add it to libbpf repo and maybe include it into sync workflow.

Should be easy enough, the update script I merged works just as well for libbpf, and we can call it from the sync-up script. I'll send the PR.

qmonnet commented 6 months ago

https://github.com/libbpf/libbpf/pull/800