search

libbpf / ci

BPF CI
Other
10 stars 24 forks source link

Introduce get-llvm-version action #27

Closed danielocfb closed 2 years ago

danielocfb commented 2 years ago

Whenever development on a new LLVM version starts, earlier versions of llvm, clang, and lld may seize to exist in distribution snapshot repositories. For us, that means having to manually bump the version in three repositories [0][1][2], in a specific order. That's cumbersome to do and ultimately we probably want a single source of truth as to what the most recent LLVM version to use is. This change introduces an action that centralizes this information while making it available across repository boundaries. We will subsequently be able to eliminate hardcoded version information in the other two repositories constituting the BPF CI.

[0] https://github.com/kernel-patches/vmtest/pull/107 [1] https://github.com/libbpf/libbpf/pull/542 [2] https://github.com/libbpf/ci/pull/24

danielocfb commented 2 years ago

This pull request illustrates usage: https://github.com/kernel-patches/vmtest/pull/114

danielocfb commented 2 years ago

Have you had a chance or do you intend to look at this change, @mykola-lysenko ?

danielocfb commented 2 years ago

I think that in the future it may be possible to move away from an action that is actively shared between repositories to just having all logic pertaining LLVM versioning centralized here (in the script), but let's move on step at a time.

mykola-lysenko commented 2 years ago

Thanks @d-e-s-o for putting it together, I like that approach and direction.