search

libbpf / ci

BPF CI
Other
11 stars 24 forks source link

Change upstream kernel configuration to compile everything built-in #29

Closed robertosassu closed 2 years ago

robertosassu commented 2 years ago

Change the upstream kernel configuration by replacing =m with =y, to force the CI to build everything built-in, since kernel modules are not copied to the virtual machine where selftests run.

Signed-off-by: Roberto Sassu roberto.sassu@huawei.com

danielocfb commented 2 years ago

Hi @robertosassu , could you detail the problem you are trying to solve some more, please? Would it make sense to rather adjust the upstream config?

Edit: Okay, I got context now (I saw this message first before reading bpf email). But I think the questions still stands: would it be better to adjust upstream configuration? I don't believe there is a real reason behind the =m choices (at least I am not aware of any). So if we can just compile them in, that seems more appropriate. It would also be great to check that vmtest.sh works correctly.

danielocfb commented 2 years ago

It seems we do not need this pull request anymore given recent upstream proposal: https://lore.kernel.org/bpf/20220818173539.q47uycc2oy5kkezl@muellerd-fedora-PC2BDTX9/T/#u

Let's convert this to a draft until we got clarity upstream.

danielocfb commented 2 years ago

Upstream change seems to have landed. Closing.