search

libbpf / ci

BPF CI
Other
10 stars 23 forks source link

Make Qemu image path configurable #31

Closed danielocfb closed 2 years ago

danielocfb commented 2 years ago

The path to the file system image used by our invocation of Qemu is currently hard coded to /tmp/root.img. This constant originates in the run_vmtest.sh script, but is then hard-coded in other locations as well, without an obvious connection between the two. That makes it hard to understand the code. This change makes the path to the image an explicit input parameter to the prepare-rootfs action and the run_vmtest.sh script, which will make it possible to make the input-output relationship more obvious in client code moving forward.

Signed-off-by: Daniel Müller deso@posteo.net

danielocfb commented 2 years ago

Note that right now the input argument has a default value in order to not break any of the clients of this action. Once they are adjusted we can (and should) remove the default.