search

libbpf / ci

BPF CI
Other
10 stars 23 forks source link

Remove default value for image-output argument #33

Closed danielocfb closed 2 years ago

danielocfb commented 2 years ago

With both vmtest [0] and libbpf [1] now providing the image-output argument to the prepare-rootfs action, we no longer need it to have a default value. Remove it and make the input required.

[0] https://github.com/kernel-patches/vmtest/commit/281b3c8bfdea9748783e18ec2eafa5736525b72f [1] https://github.com/libbpf/libbpf/commit/69938da6d7748a7b445954a959288b15bf9d8c38

Signed-off-by: Daniel Müller deso@posteo.net

mykola-lysenko commented 2 years ago

as libbpf/ci do not test things, did you try to run it in libbpf/libbpf and kernel-patches/vmtest ?

danielocfb commented 2 years ago

On vmtest, yes -- the change was included in all my recent test runs. libbpf not explicitly, as the relevant logic there is the same as in vmtest.