search

libbpf / ci

BPF CI
Other
10 stars 23 forks source link

Remove default arguments from prepare-rootfs action #34

Closed danielocfb closed 2 years ago

danielocfb commented 2 years ago

Having default arguments on an action should probably be avoided if possible. For one, it's confusing to see something being "required" but having a default value, but if not explicitly mentioned on the call site, it's also unnecessarily hard to understand what is going on.

With https://github.com/libbpf/libbpf/pull/570 merged we no longer need default values for two arguments to the prepare-rootfs action, as all call sites explicitly provide values. Hence, remove them.

Signed-off-by: Daniel Müller deso@posteo.net

danielocfb commented 2 years ago

vmtest run: https://github.com/kernel-patches/bpf/actions/runs/2958202481

chantra commented 2 years ago

Thanks! Looking forward for this. Following github actions has been very confusing in the past and I agree that being explicit here is probably better.