We need qemu-user-static.service to be started once to set up binfmt... Currently, this is set as a "oneshot" service, which runs and then is done.
The problem is that we have a dependency from the runners to qemu-user-static. When the runner restarts, qemu-user-static is not "active" (but "inactive/dead" instead), so it starts it. Because we use --reset in qemu-user-static, there is a time window when binaries from a foreign architecture won't be handled properly. Possibly in the middle of a runner run.
This change adds RemainAfterExit=yes to qemu-user-static, which has the effect of keeping the unit as "active" so it does not restart it.
This was tried on bpf-ci-runner-s390x-5 and could confirm that when a runner restarted, the qemu-user-static service was not restarted.
We need qemu-user-static.service to be started once to set up binfmt... Currently, this is set as a "oneshot" service, which runs and then is done. The problem is that we have a dependency from the runners to
qemu-user-static. When the runner restarts,qemu-user-staticis not "active" (but "inactive/dead" instead), so it starts it. Because we use--resetinqemu-user-static, there is a time window when binaries from a foreign architecture won't be handled properly. Possibly in the middle of a runner run. This change addsRemainAfterExit=yestoqemu-user-static, which has the effect of keeping the unit as "active" so it does not restart it.This was tried on
bpf-ci-runner-s390x-5and could confirm that when a runner restarted, theqemu-user-staticservice was not restarted.Signed-off-by: Manu Bretelle chantr4@gmail.com