search

libbpf / libbpf-sys

Rust bindings to libbpf from the Linux kernel
https://crates.io/crates/libbpf-sys/
BSD 2-Clause "Simplified" License
193 stars 47 forks source link

Clarification on the metadata in semvar version #58

Closed yihuaf closed 1 year ago

yihuaf commented 1 year ago

Hi, I want to ask about the metadata in the semvar version since it produces the warning:

version requirement 1.1.1+v1.0.1 for dependency libbpf-sys includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion

If I understand this correctly, the +v1.0.1 is for information only to indicate to a human reader which libbpf version is used from upstream. Therefore, if needed, we can safely remove the metadata version from cargo manifest?

danielocfb commented 1 year ago

Thanks for bringing this up. Yes, it can likely be ignored. See https://doc.rust-lang.org/cargo/reference/resolver.html#version-metadata

yihuaf commented 1 year ago

Thanks for bringing this up. Yes, it can likely be ignored. See https://doc.rust-lang.org/cargo/reference/resolver.html#version-metadata

Thank you!