search

libcdio / libcdio-paranoia

CD paranoia on top of libcdio
GNU General Public License v3.0
48 stars 37 forks source link

Use AC_PROG_MKDIR_P where required #1

Closed ssuominengentoo closed 11 years ago

ssuominengentoo commented 11 years ago

$(mkdir_p) is deprecated, and mkdir -p shouldn't be hardcoded, the most modern way I know this should be called is AC_PROG_MKDIR_P in configure.ac and $(MKDIR_P) in Makefile.am files

  1. Add AC_PROG_MKDIR_P to configure.ac
  2. Change $(mkdir_p) with $(MKDIR_P) in doc/ja/Makefile.am
  3. Remove old AC_SUBST and mkdir_p hacks from configure.ac as useless

However if you compare doc/en/Makefile.am with doc/ja/Makefile.am it seems there is more modernisation to be done that would simplify this even futher :)

rocky commented 11 years ago

Ok. Thanks for the information. I saw your patch on Savannah. If you could fork this github code, change it, and issue a merge request, that would be great. Also, you'll get full credit for your change.

Likewise for diffs between doc/en/Makefile.am and doc/ja/Makefile.am.

Thanks.

rocky commented 11 years ago

Patch applied in commit #38273

ssuominengentoo commented 11 years ago

I don't mind credits. Sorry for not doing proper puil request, I'm really grasping here trying to push too many patches at once...

Hey. I believe this part of the configure.ac can now be deleted as unused:

dnl dnl Newest automake workaround - needed for multi-language manual pages dnl AC_SUBST(mkdir_p)

rocky commented 11 years ago

Ok. AC_SUBST(mkdir_p) removed in commit 84cdb73