search

libcheck / check

A unit testing framework for C
GNU Lesser General Public License v2.1
1.08k stars 209 forks source link

Issue 10 website news tab causes download #308

Closed jflopezfernandez closed 4 years ago

jflopezfernandez commented 4 years ago

Commit

As the related issue documents, GitHub pages cannot determine the file type of the NEWS or LGPL files because they do not have a file extension, so the server uses a default MIME type of application/octet-stream, which triggers a download, rather than letting the user actually read the file.

To circumvent this problem, I changed to file links from relative links to full hyperlinks referencing the GitHub repository URL instead. The NEWS file is now viewable via the "raw" view option accessible through GitHub, and the LGPL file links to the GitHub license file default.

I chose not to simply use the raw view for the license file since I felt most people looking at that file would probably not be lawyers, and would therefore benefit from the summary GitHub displays at the top of the page.

Notes

I tested the links using the Firefox web developer tools.

This pull request fixes issue #10

jflopezfernandez commented 4 years ago

This pull request sought to merge the changes to the master branch instead of the GitHub pages branch.