search

libcheck / check

A unit testing framework for C
GNU Lesser General Public License v2.1
1.07k stars 209 forks source link

cmake_minimum_required(...) has a wrong version required #325

Open woniua opened 3 years ago

woniua commented 3 years ago

In tag '0.15.2' and later, the cmake_minimum_required(...) is version 3.9 required in top level CMakeLists.txt, In this file, the funcion add_link_options(...) is invoked at line 251 and it`s news from CMAKE version 3.13.

Does the cmake_minimum_required(...) should correct into cmake_minimum_required(VERSION 3.13)?

mikkoi commented 3 years ago

Hi. Yes. That's clearly wrong. CMake minimum version should be raised to 3.13. Thanks for noticing it. Could you make a pull request?

mikkoi commented 2 years ago

Fixed in PR https://github.com/libcheck/check/pull/338