search

libcheck / check

A unit testing framework for C
GNU Lesser General Public License v2.1
1.08k stars 209 forks source link

Glenn Washburn's JUnit patch was never merged back then. What happened? #334

Open joakimr-axis opened 3 years ago

joakimr-axis commented 3 years ago

For integration with various CI pipeline tools with JUnit format support, it would be nice to have JUnit output from check directly instead of relying on external converters such as check2junit.py. It seems from the mailinglist archives that Glenn Washburn did a patch for this back in the days

https://sourceforge.net/p/check/mailman/message/2963561/

and that it was positively received bu the maintainers. Apparently, a larger refactorization was done around that time; was that JUnit patch then never updated to match the new codebase and forgotten?

I did some experiments with applying it to the contemporary codebase, but there is a bit more than simple fixes needed to make things roll with the current codebase design. (And then some better knowledge of check and JUnit than mine is needed.)

brarcher commented 3 years ago

was that JUnit patch then never updated to match the new codebase and forgotten?

My understanding from reading through the conversation is that the patches stalled out when asking for adding documentation to go along with adding support for JUnit XML output.

The Check project would be up for reviewing this feature again, if a volunteer from the community would be available to adapt the patches and create a pull request in GitHub.

trevershick commented 3 years ago

I didn't add the timing yet, but I have the Junit XML format being outputted in #337 . I'll add the timing after this initial PR, if it gets merged.