search

libcord-tech / gauntlet

A keybinding tool for defending quickly in NationStates.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Return to activity page after crossing and dossing #15

Closed esfalsa closed 1 year ago

esfalsa commented 1 year ago

Closes #11

I ended up going with a success notification rather than pop-up, partly because calling notyf.success() was easier than making a pop-up 😛. But also I think there is a use case for quickly cross-endorsing or dossing from the activity feed again (e.g. a user switches and cross-endorses quickly, then sees there are newer admits on their activity feed that they didn't endorse) where saving a keybind to dismiss a pop-up would be more ergonomic.

roavin commented 1 year ago

I'll approve and merge after the copy-paste error is fixed. @esfalsa

esfalsa commented 1 year ago

I think I missed a memo somewhere 😅 — what copy-paste error are you referring to?

Edit: And then I found one... I didn't spot any others but do let me know if that's not the one you spotted.

roavin commented 1 year ago

Huh, does GitHub not show you the Review comment I added?

esfalsa commented 1 year ago

Yeah, I'm not seeing anything — at least, not where the GitHub docs say it should be. It's not showing me a PR review from you at all, which I'd suspect is why I also can't see any line comments that are part of that review?