search

libcpr / cpr

C++ Requests: Curl for People, a spiritual port of Python Requests.
https://docs.libcpr.org/
Other
6.29k stars 903 forks source link

Broken on Windows with HTTPS and Curl 8.8.0 (works with 8.6.0) #1068

Open fhoenig opened 4 days ago

fhoenig commented 4 days ago

Description

Windows version seems to not be compatible with curl 8.8.0. Build with nmake static lib x64 and with windows's sspi.

Example/How to Reproduce

  1. call cpr::Response r = cpr::Get(cpr::Url{ "https://api.github.com/repos/whoshuu/cpr/contributors" });
  2. See error (CURLE_BAD_FUNCTION_ARGUMENT)

Possible Fix

No response

Where did you get it from?

GitHub (branch e.g. master)

Additional Context/Your Environment

COM8 commented 4 days ago

I discarded the update to curl 8.8.0 (https://github.com/libcpr/cpr/pull/1054) since it does not work with MbedTLS.

Please provide a detailed error log.

COM8 commented 4 days ago

The CI at least worked for curl 8.8.0: https://github.com/libcpr/cpr/actions/runs/9225854129/job/25408143763