search

libcpr / cpr

C++ Requests: Curl for People, a spiritual port of Python Requests.
https://docs.libcpr.org/
Other
6.55k stars 933 forks source link

cpr::ProgressCallback in combination with cpr::Download has the values of up- and download switched #1092

Closed Binary-System closed 1 month ago

Binary-System commented 3 months ago

Description

Following the examples from the docs and combining cpr::download with cpr::CallbackProgress gives wrong values in the callback function.

downloadTotal stays at 0 downloadNow stays at 0 uploadNow stays at 0 uploadTotal shows bytes transferred

I expected the transferred bytes in downloadNow and in downloadTotal the expected resulting filesize (to calculate transfer percent)

Example/How to Reproduce

Use following code

cpr::Response r = cpr::Download(of, 
    cpr::Url{ "https://mydomain/file" },
    cpr::ProgressCallback([&](cpr::cpr_off_t downloadTotal, cpr::cpr_off_t downloadNow, cpr::cpr_off_t uploadTotal, cpr::cpr_off_t uploadNow, intptr_t userdata) -> bool {
    TRACE("downloadTotal: %ld downloadNow: %ld uploadTotal: %ld uploadNow: %ld \r\n", downloadTotal, downloadNow, uploadTotal, uploadNow);
    return true;}
));

downloadTotal stays at 0 downloadNow stays at 0 uploadNow stays at 0 uploadTotal shows bytes transferred

Output from Visual Studio Console:

atlTraceGeneral - downloadTotal: 0 downloadNow: 0 uploadTotal: 5979640 uploadNow: 0

I expected the transferred bytes in downloadNow and in downloadTotal the expeced resulting filesize (to calculate transfer percent)

Possible Fix

No response

Where did you get it from?

vcpkg

Additional Context/Your Environment

COM8 commented 2 months ago

@Binary-System thanks for reporting! I can not reproduce this. For me it works perfectly as intended:

#include <iostream>
#include <cpr/cpr.h>

int main(int /*argc*/, char** /*argv*/) {
    std::ofstream outFs("my.iso", std::ios::binary);
    cpr::Response response = cpr::Download(outFs,
                                           cpr::Url{"https://mirror.funkfreundelandshut.de/ubuntu-releases/24.04/ubuntu-24.04-live-server-amd64.iso"},
                                           cpr::ProgressCallback([&](cpr::cpr_off_t downloadTotal, cpr::cpr_off_t downloadNow, cpr::cpr_off_t uploadTotal, cpr::cpr_off_t uploadNow, intptr_t /*userdata*/) -> bool {
                                               const double downloadPercentage = static_cast<double>(downloadNow) / static_cast<double>(downloadTotal) * 100;
                                               const double uploadPercentage = static_cast<double>(uploadNow) / static_cast<double>(uploadTotal) * 100;
                                               std::cout << "downloadTotal " << downloadTotal << " downloadNow " << downloadNow << " downloadPercentage " << downloadPercentage << "% uploadTotal " << uploadTotal << " uploadNow " << uploadNow << " uploadPercentage" << uploadPercentage << "%\n";
                                               return true;
                                           }));
    return 0;
}
downloadTotal 2754981888 downloadNow 1971533 downloadPercentage 0.0715625% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1971533 downloadPercentage 0.0715625% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1971533 downloadPercentage 0.0715625% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1987853 downloadPercentage 0.0721548% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1987853 downloadPercentage 0.0721548% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1987853 downloadPercentage 0.0721548% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1987853 downloadPercentage 0.0721548% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1987853 downloadPercentage 0.0721548% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1987853 downloadPercentage 0.0721548% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1987853 downloadPercentage 0.0721548% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1987853 downloadPercentage 0.0721548% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1987853 downloadPercentage 0.0721548% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 1987853 downloadPercentage 0.0721548% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2004173 downloadPercentage 0.0727472% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2020493 downloadPercentage 0.0733396% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2020493 downloadPercentage 0.0733396% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2020493 downloadPercentage 0.0733396% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2020493 downloadPercentage 0.0733396% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2020493 downloadPercentage 0.0733396% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2020493 downloadPercentage 0.0733396% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2020493 downloadPercentage 0.0733396% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2020493 downloadPercentage 0.0733396% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2020493 downloadPercentage 0.0733396% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2020493 downloadPercentage 0.0733396% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2036813 downloadPercentage 0.073932% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2053133 downloadPercentage 0.0745244% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2053133 downloadPercentage 0.0745244% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2053133 downloadPercentage 0.0745244% uploadTotal 0 uploadNow 0 uploadPercentage-nan%
downloadTotal 2754981888 downloadNow 2053133 downloadPercentage 0.0745244% uploadTotal 0 uploadNow 0 uploadPercentage-nan%

I'm testing with cpr 1.10.5 and inside the example-cmake-fetch-content.

COM8 commented 1 month ago

Closing for no response. Feel free to reopen in case the issue still persists.