search

libdns / googleclouddns

Google Cloud DNS provider implementation for libdns interfaces
MIT License
11 stars 5 forks source link

Only return public zones #1

Closed golgeek closed 3 years ago

golgeek commented 3 years ago

There are situations where you can have two different Cloud DNS zones for the same DNS name, eg:

During DNS challenge for ACME validation process with the following module, if the private zone is returned by getCloudDNSZone, then the TXT entry will be created in the private zone, and will never be publicly resolved.

This PR adds a filtering on public zones to avoid pushing TXT entries to private zones.

golgeek commented 3 years ago

@brockwood not sure how to add you as a reviewer :)

I'm happy to do update the PR if you're not satisfied with the way it's done right now

brockwood commented 3 years ago

@brockwood not sure how to add you as a reviewer :)

I'm happy to do update the PR if you're not satisfied with the way it's done right now

Thanks for pointing out this use case! The PR looks great so no further change is needed. I'll get the caddy-dns/googleclouddns library updated next.

brockwood commented 3 years ago

@golgeek The updated release is out there: https://github.com/caddy-dns/googleclouddns/releases/tag/v1.0.2

Thanks again for your contribution!

golgeek commented 3 years ago

Awesome, thank you for merging and updating the caddy-dns module quickly!