search

libdns / hetzner

Hetzner DNS implementation for libdns
MIT License
5 stars 8 forks source link

New DNS Provider: Vercel #2

Closed fairhat closed 3 years ago

fairhat commented 3 years ago

Hello,

I've forked the Hetzner Repository and modified it to work with domains that are managed by Vercel (vercel.com). It uses the vercel API, the tests pass (just not the TTL value in GetRecord since Vercel's API does not return any TTL values).

Can we get this as an official libdns package? (I would like to use it on Caddyserver)

I didn't know where to open the request, obviously this i don't want this to be merged into hetzner.

mholt commented 3 years ago

Yes, that would be fine. I will take a look at this asap and make new repos for vercel.

mholt commented 3 years ago

Just did a quick glance, LGTM. I made the vercel repos and gave you maintain access, so you can go to town there. (FYI in the future, we ask that new DNS providers be reviewed at libdns/libdns, not in random other repos.)

Be sure to update package and module paths. Once it's ready you can add it to the Caddy website. Thanks!

fairhat commented 3 years ago

Just did a quick glance, LGTM. I made the vercel repos and gave you maintain access, so you can go to town there. (FYI in the future, we ask that new DNS providers be reviewed at libdns/libdns, not in random other repos.)

Be sure to update package and module paths. Once it's ready you can add it to the Caddy website. Thanks!

Done! What exactly do i add to the website?

The module works, even though it errors twice before getting a wildcard certificate but after that, everything's fine!

mholt commented 3 years ago

even though it errors twice before getting a wildcard certificate but after that

That isn't normal, try to make sure it works the first time. :)

fairhat commented 3 years ago

even though it errors twice before getting a wildcard certificate but after that

That isn't normal, try to make sure it works the first time. :)

Deleted the certificates and restarted caddy, this time it worked without errors, maybe a vercel api problem earlier.

Will take a closer look in the next few days and if i can't reproduce it, i'll put a warning in the Readme!