search

libdynd / dynd-python

Python exposure of dynd
http://libdynd.org
Other
119 stars 23 forks source link

Fix DLL preload for the libdynd default install location. #710

Closed skrah closed 8 years ago

skrah commented 8 years ago

This fixes the dll preload if libdynd is installed in Program Files.

Two more things:

1) I tried to remove the ImportError from dynd\___init__.py. This is surprisingly
    tricky if you want to have the same dynd\__init__.py file for both dynd.ndt
    and dynd.nd.  Having the same file is easier logistically.

2) I removed the namespace cleanups "del common" etc. since some of those
    were not robust.
insertinterestingnamehere commented 8 years ago

Thanks! This looks right to me. Is this good to merge?

skrah commented 8 years ago

Yes, this should be good.

insertinterestingnamehere commented 8 years ago

Okay, I see a similar commit in https://github.com/libdynd/dynd-python/pull/712 is this going to throw that PR off at all?

skrah commented 8 years ago

No, #712 is branched off this. You can either merge that and close this one or I update the master after this is merged.

insertinterestingnamehere commented 8 years ago

Got it. I'll just review that one now.

insertinterestingnamehere commented 8 years ago

Merged as a part of https://github.com/libdynd/dynd-python/pull/712.