search

libdyson-wg / libdyson-neon

Python library for dyson devices
Apache License 2.0
20 stars 12 forks source link

Check for blank LocalCredentials instead of None during sign in #19

Closed rubyroobs closed 9 months ago

rubyroobs commented 9 months ago

I couldn't get the auto-setup to work with my "MyDyson" account in either Home Assistant or with the local tool. Upon looking at the trace locally I found this line and figured I'd try changing it from is None to not in case the API changed (I have 2 Lightcycles) - as soon as I did it worked fine.

dotvezz commented 9 months ago

That test failure is because of an outdated codecov config. I'll update and rerun later.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1e8b946) 99.12% compared to head (7e652f3) 99.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #19 +/- ## ======================================= Coverage 99.12% 99.12% ======================================= Files 22 22 Lines 1025 1025 ======================================= Hits 1016 1016 Misses 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.