liberatedsystems / RNode_Firmware_CE

RNode is an open, free and flexible digital radio interface with many uses
https://unsigned.io/rnode
GNU General Public License v3.0
51 stars 11 forks source link

python3 issue with makefile #33

Closed faragher closed 2 months ago

faragher commented 2 months ago

When doing make -upload-X on Debian 12 or similar systems that lack "python" redirecting to "python3" breaks when esptool.py is called. I don't have a good solution for this as while symlinking python -> python3 was long considered good practice, apparently at least Debian is moving away from it.

tomuk5 commented 2 months ago

Having this same issue, installing the package python-is-python3 creates this symlink on debian systems without manual intervention.

sudo apt-get install python-is-python3

In the Long-term all references to python should be replaced with python3 then this transitional package can be removed.

jeremybox commented 2 months ago

One of the changes in https://github.com/liberatedsystems/RNode_Firmware_CE/pull/35 addresses this.

jacobeva commented 2 months ago

That's pretty gay.

In the Long-term all references to python should be replaced with python3 then this transitional package can be removed.

Agreed.

tomuk5 commented 2 months ago

PEP394 covers this eventuality:

In order to tolerate differences across platforms, all new code that needs to invoke the Python interpreter should not specify python, but rather should specify either python2 or python3 (or the more specific python2.x and python3.x versions; see the Migration Notes_). This distinction should be made in shebangs, when invoking from a shell script, when invoking via the system() call, or when invoking in any other context.

jacobeva commented 2 months ago

Thanks for the info!

On 24/09/11 01:38am, Thomas Wing wrote:

PEP394 covers this eventuality:

In order to tolerate differences across platforms, all new code that needs to invoke the Python interpreter should not specify python, but rather should specify either python2 or python3 (or the more specific python2.x and python3.x versions; see the Migration Notes_). This distinction should be made in shebangs, when invoking from a shell script, when invoking via the system() call, or when invoking in any other context.

-- Reply to this email directly or view it on GitHub: https://github.com/liberatedsystems/RNode_Firmware_CE/issues/33#issuecomment-2343012611 You are receiving this because you commented.

Message ID: @.***>