search

liberatedsystems / RNode_Firmware_CE

RNode is an open, free and flexible digital radio interface with many uses
https://unsigned.io/rnode
GNU General Public License v3.0
51 stars 11 forks source link

TX power does not support negative values #4

Closed jacobeva closed 4 months ago

jacobeva commented 6 months ago

How could you propose we handle the negative TX power parameter for the SX1262 and SX1280? Should I change it in the firmware so they are offset so that all the values are positive? Or is it possible to implement these as negative values?

Edit: Issue transferred from original at https://github.com/markqvist/RNode_Firmware/issues/63

jacobeva commented 6 months ago

The discussion for this one was very long, but is summed up by the following: "Aha, that makes sense. Well, we definitely need to solve this then ;)

In general, the current way of setting TX power was conceived way back when RNode was basically just one device, compiling on one platform, with one modem chip, so in the current implementation it is not really sufficient anymore.

We'll need to implement something more universal." @markqvist

jacobeva commented 4 months ago

Fixed in commit c88fe0e