search

liberation / django-elasticsearch

Simple wrapper around elasticsearch-py to index/search a django Model.
MIT License
211 stars 73 forks source link

py3 compatibility of basestring checks #47

Open kristoff-it opened 8 years ago

kristoff-it commented 8 years ago

aliased ‘basestring’ with ‘str’ for py3 compatibility

lauxley commented 8 years ago

Hi, thx for the PR I'm a little bit confused as to why merge this in feature/django-19 which is not py3 compatible ? Also this is not the preferred way to deal with basestring according to django's documentation https://docs.djangoproject.com/en/1.9/topics/python3/#string-handling-with-six

isinstance(myvalue, six.string_types)       # replacement for basestring