search

liberfa / erfa

Essential Routines for Fundamental Astronomy. Maintainers: @eteq @mhvk @sergiopasra
Other
131 stars 49 forks source link

ERFA 1.7 still has version number 1.6!? #62

Closed mhvk closed 4 years ago

mhvk commented 4 years ago

See https://github.com/liberfa/erfa/blob/master/src/erfaversion.c#L10

@eteq - since you did the release, it's probably easiest for you to fix... I have a PR ready for the astropy side (indeed, that is how I found out...)

sergiopasra commented 4 years ago

It's not that bad because the macros are overridden in this line

https://github.com/liberfa/erfa/blob/master/src/erfaversion.c#L25

config.h contains the correct values from configure. I agree that actual disposition of the macros is confusing. They should be used only if config.h does not exist

mhvk commented 4 years ago

Ah, that's good. I'll proceed with my PR to astropy, then.