search

liberfa / erfa

Essential Routines for Fundamental Astronomy. Maintainers: @eteq @mhvk @sergiopasra
Other
128 stars 48 forks source link

Update ERFA to SOFA 20200721. #71

Closed mhvk closed 4 years ago

mhvk commented 4 years ago

fixes #70, #66

Only small changes in SOFA.

I couldn't resist just putting in erfa version 1.8.0 instead of x.y.z, since I'd hope to go ahead and do a release too.

avalentino commented 4 years ago

@mhvk please note that there is a typo in the README.rst section "Version information":

``eraVersion`,` ``eraVersion*``, and ``eraSofaVersion`` functions that are

should be

``eraVersion``, ``eraVersion*``, and ``eraSofaVersion`` functions that are
mhvk commented 4 years ago

@avalentino - thanks! Fix in README.rst made.

mhvk commented 4 years ago

Actually, reading RELEASE.rst really carefully, since there are only bug fixes in this SOFA release, and we are not adding anything either, it should be erfa release 1.7.1, not 1.8.0.

mhvk commented 4 years ago

OK, just too annoying to try to do the numbering in two branches - now adjusted the erfa version number as well as the shared library number here. @eteq - could you please check my understanding of the erfa numbering is correct? SOFA only has bug fixes.

avalentino commented 4 years ago

Actually, reading RELEASE.rst really carefully, since there are only bug fixes in this SOFA release, and we are not adding anything either, it should be erfa release 1.7.1, not 1.8.0.

yes, you are right @mhvk

mhvk commented 4 years ago

@eteq - do you want to check the version numbering before I merge this?

sergiopasra commented 4 years ago

The version number (1.7.1) seems OK to me

mhvk commented 4 years ago

OK, @sergiopasra, thanks for the cross-check. I'll merge now!