search

liberfa / erfa

Essential Routines for Fundamental Astronomy. Maintainers: @eteq @mhvk @sergiopasra
Other
131 stars 49 forks source link

Move testing to github actions #78

Closed mhvk closed 3 years ago

mhvk commented 3 years ago

Since travis is disappearing, we need to move our tests. Who knows, this might even work!

mhvk commented 3 years ago

@astrofrog - if you have a moment, would you be able to check why actions are not running on this PR? I forget whether one has to set something for it to happen...

avalentino commented 3 years ago

On MacOSX we need to install "aclocal"? See test failure in https://github.com/avalentino/erfa/actions

mhvk commented 3 years ago

I had the ./...sh versions before, but it didn't seem anything even ran. I've now reverted to it (and set fail-fast to false so one can check independently). Not sure why nothing is running automatically here!

mhvk commented 3 years ago

@avalentino - if you have a working configuration (even with clang on linux), obviously fine to make that into a PR and merge it instead! I vaguely recall one needs to merge something first to get going...

avalentino commented 3 years ago

I have just temporarily enabled the current branch avalentino/erfa@6f1a8af3f928a7d77a090f34d4b8f3c46f8b978e

avalentino commented 3 years ago

OK @mhvk if you cherry-pick this commit avalentino/erfa@f576efa8d5edb5b3999467093205b279270df08a it should work also on MacOSX

mhvk commented 3 years ago

OK, thanks! Cherry-picked that one. It still doesn't run automatically, do you know if we just need to merge first, or have to explicitly enable it?

astrofrog commented 3 years ago

It will only run on PRs once merged (but you can check how it runs currently on your fork)

avalentino commented 3 years ago

I have checked it in my fork: https://github.com/avalentino/erfa/actions. IMHO it is safe to merge.

mhvk commented 3 years ago

OK, since it is checked, let's merge!

mhvk commented 3 years ago

Thanks, both!