liberfa / erfa

Essential Routines for Fundamental Astronomy. Maintainers: @eteq @mhvk @sergiopasra
Other
131 stars 49 forks source link

erfadatextra.h `#ifndef` #87

Closed radonnachie closed 2 years ago

radonnachie commented 2 years ago

Enables source_flattener.py to scrape until #endif and succeed.

mhvk commented 2 years ago

@RocketRoss - that looks good and makes sense - we really should have had that (just goes to show how poor my C is...)

Will just check that the tests pass - but I don't see how they could not!

radonnachie commented 2 years ago

Just the smallest oversight, happy to help patch. Only came up because of the flatten_sources.py if erfa_fetch. Thanks!

mhvk commented 2 years ago

@RocketRoss - just noticed something silly, but might as well fix it - there is a missing new-line at the end of the file. Could you fix that? (Happy to do it myself if that's easier)

radonnachie commented 2 years ago

Sorted 👍

avalentino commented 2 years ago

@mhvk I think that you need to approve the test execution in order to run tests

mhvk commented 2 years ago

@RocketRoss - thanks! Will merge once tests have run again.

radonnachie commented 2 years ago

@mhvk Success :)