search

liberfa / pyerfa

Python bindings for ERFA routines
https://pyerfa.readthedocs.io
BSD 3-Clause "New" or "Revised" License
34 stars 24 forks source link

Revert mininum numpy change #103

Closed mhvk closed 1 year ago

mhvk commented 1 year ago

This is to ensure astropy LTS does not have to pin. Added an extra test for numpy 1.20 since that was problematic before.

mhvk commented 1 year ago

@avalentino, @astrofrog - I changed the minimum version back to 1.17, given @pllim's comment that it was a problem for LTS (and that really one should not change it in a bug-fix release!). I also added a test with numpy 1.20, which had problems in #101. Here, it seems to pass (perhaps a different ubuntu version and therefore different python? I noticed that on recent python I can no longer pip install numpy==1.17 as the compilation fails...).

Anyway, would be great if you can have a look.

Once merged, all we need to do for a release is to push a tag of 2.0.0.3, right?

mhvk commented 1 year ago

Thanks, both! I'll merge now...

p.s. Indeed, LTS needs numpy >=1.18, but we used to have 1.17, so I thought I might as well put it back to what it was. With the next ERFA release, we can make a bigger jump.

pllim commented 1 year ago

Thanks again for the quick fix! Related follow-up PRs: