search

libero / walking-skeleton

A walking skeleton of the scholarly publishing system
MIT License
7 stars 2 forks source link

Don't create the articles exchange in the dashboard #36

Closed thewilkybarkid closed 6 years ago

thewilkybarkid commented 6 years ago

Currently the articles exchange isn't created until a message is sent, so the queue will miss the first message.

giorgiosironi commented 6 years ago

Currently the articles exchange isn't created until a message is sent

That's a bug in the article store?

seanwiseman commented 6 years ago

Currently the articles exchange isn't created until a message is sent, so the queue will miss the first message.

'Might' miss the first message, as the exchange is created and then a message is sent. Between the creation and sending a bind could happen, though granted its unlikely.

That's a bug in the article store?

The creation/check of the exchange before sending is really just a precaution, perhaps we need to formalize the creation of the exchange to make it more predictable? we can't really have messages being missed.

giorgiosironi commented 6 years ago

really just a precaution, perhaps we need to formalize the creation of the exchange to make it more predictable?

Should happen on bootstrap or before the application is started imho, like for the relational database schema.

seanwiseman commented 6 years ago

Agreed. I will add that in.