search

libersys / rtp-ogg-opus

RTP Ogg/Opus Tools for NodeJS
Other
13 stars 2 forks source link

Doesn't build on Apple Silicon Mac #5

Open diogeneshamilton opened 9 months ago

diogeneshamilton commented 9 months ago

Not sure if this repo is maintained anymore, I tried seeing if I could fix, but just reporting here that it does not seem to build on Mac arm64. Probably related to https://github.com/discordjs/opus/issues/98, getting this error:

`gyp info spawn make gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ] CC(target) Release/obj.target/libogg/deps/libogg/src/framing.o CC(target) Release/obj.target/libogg/deps/libogg/src/bitwise.o LIBTOOL-STATIC Release/ogg.a CC(target) Release/obj.target/libopus/deps/libopus/src/opus_multistream.o ../deps/libopus/src/opus_multistream.c:29:10: fatal error: 'config.h' file not found

include "config.h"

     ^~~~~~~~~~`

I was able to copy over the config.h file from @discordjs/opus, but still got this error:

In file included from ../deps/libopus/silk/SigProc_FIX.h:51: ../deps/libopus/silk/arm/biquad_alt_arm.h:31:11: fatal error: 'celt/arm/armcpu.h' file not found # include "celt/arm/armcpu.h" ^~~~~~~~~~~~~~~~~~~

dioris-moreno commented 9 months ago

Hi @diogeneshamilton,

@jbaudanza reports a similar issue and he solved it by adding the following settings to binding.gyp:

"conditions": [ ['OS=="mac"', { "xcode_settings": { "GCC_ENABLE_CPP_EXCEPTIONS": "YES" } }] ],

These settings were added on version v1.0.13.

I'm a PC guy and I can't reproduce the issue you are reporting.

Please open a PR if you find a solution.

diogeneshamilton commented 9 months ago

Thanks! Yeah I am using that version which has that change already, but does not seem to resolve. I will report back if I get it fixed!