libertyernie / brawltools

BrawlBox and BrawlLib
http://forums.kc-mm.com/index.php?topic=67847.0
143 stars 31 forks source link

BrawlBox v0.78's progress bar is jumpy when playing BRSTMs #137

Closed PhoenixClank closed 7 years ago

PhoenixClank commented 7 years ago

The timer goes up way too slowly, then jumps to the correct value every so often. Same thing with the progress bar. This is just a visual glitch; audio playback is not affected. This was not an issue in BrawlBox v0.77.

libertyernie commented 7 years ago

Perhaps this has something to do with OpenAL. BrawlBox will use OpenAL if it can, and fall back to DirectSound if it can't (and it's running on Windows.)

Right now there's no setting to turn off OpenAL or tell if you're using it, but I'd like to add one.

Does it also happen in the BRSTM creation window (when it asks you for a loop point?)

PhoenixClank commented 7 years ago

(I gotta work on my spam filters.) Yes, this also happens in the BRSTM creation window. Also I've noticed when I open BrawlBox by double-clicking an existing BRSTM and then want to create a new BRSTM, the creation window plays the audio way too fast. When I cancel out of the creation, the original window doesn't play the audio at all. (Also, is it normal that the resulting loop points aren't exactly the ones you type in? I have no idea how BRSTMs actually work.)

libertyernie commented 7 years ago

@JoFelix2 The loop point has to be a multiple of 14336, so it will add the same amount to both start and end points to make it work.

I bet OpenAL is the problem. In the next version I'll make it prefer DirectSound when available.

PhoenixClank commented 7 years ago

Why do the loop points have to be multiples of 14336, and what happens if I edit them in a hex editor? (Also yay my spam filters work now.)

libertyernie commented 7 years ago

14336 is the block size. I don't know what happens if you edit it with a hex editor - maybe the Wii won't play it properly?

libertyernie commented 7 years ago

Try the BrawlBox.exe in this zip file. It's just like 0.78 hotfix 1, except it uses DirectSound instead of OpenAL if it can. You'll need the other files (.dll, etc) from 0.78 hotfix 1. BrawlBox.zip

PhoenixClank commented 7 years ago

It's still jumpy both in the original window and in the BRSTM creation window. The creation window still plays it way too fast when I create a new BRSTM "on top of" an existing one. The only thing that's changed is that when I run BrawlBox directly (aka not by double-clicking an existing BRSTM), Windows SmartScreen tells me it doesn't trust the app.

libertyernie commented 7 years ago

Oh, it just occurred to me that the file I needed to give you was brawllib.all, not brawlbox.exe. Ill do that later today.

On Jul 30, 2017 8:56 AM, "JoFelix2" notifications@github.com wrote:

It's still jumpy both in the original window and in the BRSTM creation window. The creation window still plays it way too fast when I create a new BRSTM "on top of" an existing one. The only thing that's changed is that when I run BrawlBox directly (aka not by double-clicking an existing BRSTM), Windows SmartScreen tells me it doesn't trust the app.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/libertyernie/brawltools/issues/137#issuecomment-318903407, or mute the thread https://github.com/notifications/unsubscribe-auth/ADj1Sy25fZcXrvvZc_SwcXz1TtRZK_gcks5sTIuRgaJpZM4OY-h9 .

libertyernie commented 7 years ago

BrawlLib.zip Here's the BrawlLib.dll file. It goes in the lib folder.

PhoenixClank commented 7 years ago

Thanks, it works like a charm! (Also I re-replaced the .exe so SmartScreen doesn't bug me.)