libertyernie / brawltools

BrawlBox and BrawlLib
http://forums.kc-mm.com/index.php?topic=67847.0
142 stars 31 forks source link

EditAllDialog: Transformations are applied to all planes #171

Closed Ebola16 closed 6 years ago

Ebola16 commented 6 years ago

Follow up to #90

capture11

"Replace", "Multiply", and "Divide" will apply a transformation to all planes (x,y,z). Since users can switch between addition and multiplication, a single default value is problematic.

Perhaps planes should have their default values set to N (null), which would not apply a transformation to the animations? This allows a user to be able to multiply one plane without worrying about the others. It will also prevent users from accidentally multiplying by 0 or adding 1 if they aren't careful about which operation they're using.

A small text box should also be added explaining what N means.

libertyernie commented 6 years ago

Could we just use the word "null" instead of the letter N? Or maybe an empty string would be better.

Ebola16 commented 6 years ago

Oh yeah, I like the empty string idea.

libertyernie commented 6 years ago

This seems to be working for me.

Ebola16 commented 6 years ago

LGTM. Thanks!