PAT0 (v4) doesn't save properly.

libertyernie / brawltools

BrawlBox and BrawlLib

http://forums.kc-mm.com/index.php?topic=67847.0

142 stars 31 forks source link

PAT0 (v4) doesn't save properly. #192

Open ReservedJV opened 6 years ago

ReservedJV commented 6 years ago

For some reason v4 PAT0 files cannot save properly. When multiple entries are present, all subsequent entries revert to the original version. This is not game-specific and is rather a problem with BrawlBox itself. Recreating it is very easy.

1.) Create a new Texture Pattern and set NewPAT version to 4. 2.) Create new entry on NewPAT, then create two new entries on NewNode. 3.) Change the name of Texture1's NewTexture to anything (ie: NewTexture1).

Upon saving the file and re-opening it, it is reverted from NewTexture1 to the original NewTexture, which is the texture specified in the first entry. I'm assuming this would be an easy fix because everything else about v4 saving works except this issue. However, because this issue affects the texture used...it defeats the entire purpose of PAT0 unless you're only using one entry.

Thanks for giving this your time, hoping it can be fixed soon~

ReservedJV commented 6 years ago

Another quick issue: v4 PAT0 isn't able to save palettes, either. This applies to all entries, first included. The palettes just disappear upon being saved.

Also, if it's needed, I can send an animation .brres with working v4 PAT0, might be helpful to see how it should be set up?

libertyernie commented 6 years ago

I can't speak for any of the other developers, but I'm not that familiar with PAT0. Did this ever work in old versions of BrawlBox?

I haven't looked at the code, but I wonder if it's just forgetting to set the dirty flag on that node when you change the name.

ReservedJV commented 6 years ago

I haven't checked with every version of BrawlBox but from what I've seen this issue has always been present, I think. At the very least BrawlBox is actually able to save the palette & texture data into the PAT0 file under the lists, it just doesn't save them to the entries properly.

The issue might be a simple fix, but otherwise if needed I can send a PAT0 file w/ working v4 animation (from an existing game) and also could probably provide documentation. Thanks for the reply!

libertyernie commented 6 years ago

I noticed two things:

The problem only seems to affect the last entry on NewNode. Maybe you could get around it by adding an extra entry you don't need?
It doesn't seem to happen with the latest BrawlBox code in the master branch - but I'm not really sure why.

TheGameratorT commented 5 years ago

I also face the same problem and it's very annoying

EDIT: Ended up fixing by adding a dummy frame at the end of the PAT0