libertyernie / brawltools

BrawlBox and BrawlLib
http://forums.kc-mm.com/index.php?topic=67847.0
142 stars 31 forks source link

Crashes when trying to replace audio file #202

Open nanogram opened 5 years ago

nanogram commented 5 years ago

editing mariokart wii character sfx, cant replace files without crashing

libertyernie commented 5 years ago

Is there an error message or stack trace that you can post or take a screenshot of?

nanogram commented 5 years ago

capture

nanogram commented 5 years ago

that error occurs when i try and replace the file containing the sound effects(.brstm file) for a certain character(DK, for example) when I saw that method resulted in a crash, i knew another possible way would be to go to another directory in the revo_kart.brsar that contains the essentially all the sound effect files in .wav fomat. but trying to replace any of those makes the app freeze for 3 seconds, then closes. no errors or warnings.

libertyernie commented 5 years ago

I get a similar error. Unfortunately I'm not sure how to fix it.

I wonder if BrawlCrate might work? There are some changes BrawlBox has that BrawlCrate doesn't, and vice versa.

nanogram commented 5 years ago

hmm, that might help, thx for your assistance

On Wed, Nov 14, 2018 at 5:35 PM libertyernie notifications@github.com wrote:

I get a similar error. Unfortunately I'm not sure how to fix it.

I wonder if BrawlCrate https://github.com/soopercool101/BrawlCrate might work? There are some changes BrawlBox has that BrawlCrate doesn't, and vice versa.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/libertyernie/brawltools/issues/202#issuecomment-438859156, or mute the thread https://github.com/notifications/unsubscribe-auth/AOMRMVZqOAWk0k7KEGIUUz1K_Ca8wD7Bks5uvKi3gaJpZM4YRwP9 .

nanogram commented 5 years ago

well, it kinda works, im able to modify some important files, but still getting crash without error when replacing wav files

libertyernie commented 5 years ago

If you could send me a link to a wav file that makes it crash, that might help.

nanogram commented 5 years ago

https://ufile.io/wvblm its a wav file

libertyernie commented 5 years ago

The error appears to be on this line:

https://github.com/libertyernie/brawltools/blob/master/BrawlLib/SSBB/ResourceNodes/RSAR/File%20References/RSARSoundNode.cs#L377

I don't know enough about RSAR to fix it, though.