libertyernie / brawltools

BrawlBox and BrawlLib
http://forums.kc-mm.com/index.php?topic=67847.0
143 stars 31 forks source link

Alt key no longer lags model viewer #204

Closed soopercool101 closed 5 years ago

soopercool101 commented 5 years ago

Old behavior caused MDL0 Objects to completely rebuild their materials on every render call if the Alt key (but not shift or control) is pressed. This caused major lag when using shortcuts like new collision creation in the collision editor. The functionality offered by rebuilding materials every frame when alt is pressed is not particularly useful and should just be removed outright.

Here's a comparison of before and after the fix: Before: https://gfycat.com/EmbellishedAnyGalapagosdove After: https://gfycat.com/OnlyOddEastrussiancoursinghounds

libertyernie commented 5 years ago

Do you know why that Alt key behavior was added?

I'm guessing whoever put that in, it was before the Alt key was being used for anything else.

BlackJaxDev commented 5 years ago

I added it so I could recompile the GLSL shader code on-demand for debugging purposes. No need for it anymore