libertyernie / brawltools

BrawlBox and BrawlLib
http://forums.kc-mm.com/index.php?topic=67847.0
143 stars 31 forks source link

[Request] Add in BrawlCrate updater improvements #212

Open soopercool101 opened 5 years ago

soopercool101 commented 5 years ago

I've noticed BrawlBox seems to be gearing up for an update, and I think it may be a good idea to merge in the updater improvements I've made in BrawlCrate before the next release. I can make a merge request if you'd like to use any of these improvements.

The improvements offered include:

libertyernie commented 5 years ago

I'm not sure how often there will be new releases of BrawlBox - the main reason I plan on doing one this month is because there hasn't been one in almost 2 years. There hasn't been a whole lot of activity in this repository lately either. But these sound like good ideas nonetheless.

By the way, my other Brawl apps (https://github.com/libertyernie/BrawlManagers) use BrawlCrate's version of BrawlLib now, and if there's ever anything missing from it that I need, I'll send you a pull request :)

soopercool101 commented 5 years ago

The lack of new releases is exactly why I think that support for my Canary system would be a good fit for BrawlBox. It would prevent needing to actively push out an update as a build and commit would be all that is necessary. Regardless I'll make a pull request with the updates by the end of the week and you can decide what features you wish to take advantage of.

As for the BrawlManagers, let me know if I ever break my BrawlLib's compatibility with those. I'm trying to maintain it's modularity but I know I've committed one or two developer sins that may have affected that in the quest for feature updates.

libertyernie commented 5 years ago

That makes sense, thanks!

I don't mind changes in BrawlLib that result in compiler errors, because I can catch those and fix them :)

libertyernie commented 5 years ago

Are you still working on this or is it OK if I post a release without it (if I have time)? I don't want to put pressure on you but figured I'd check.

soopercool101 commented 5 years ago

Been going through an unexpected move, but I'm officially moved in. Will have it up by Sunday, if not then by all means push a new release.